[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] conf: Use virMacAddrFormat while generating domain XML files



On 03/27/13 22:45, Eric Blake wrote:
On 03/26/2013 08:06 AM, Martin Kletzander wrote:
On 03/26/2013 12:26 PM, Peter Krempa wrote:
Format the address using the helper to avoid code duplication.
---
  src/conf/domain_conf.c | 7 +++----
  1 file changed, 3 insertions(+), 4 deletions(-)

I'd ACK that, fine use for the cleanup, but pity it's fixed on only one
place.  How about squashing in the following?

The followup also looks fine.  Is this something you were planning on
pushing in 1.0.4?

No, I'll rather wait until the release is out.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]