[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] security_manager.c: Append seclabel iff generated



On 03/28/2013 09:19 AM, Michal Privoznik wrote:
> With my previous patches, we unconditionally appended a seclabel,
> even if it wasn't generated but found in array of defined seclabels.
> This resulted in double free later when doing virDomainDefFree
> and iterating over the array of defined seclabels.
> 
> Moreover, there was another possibility of double free, if the
> seclabel was generated in the last iteration of the process of
> walking trough security managers array.

s/trough/through/

> ---
>  src/security/security_manager.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

ACK, and definite 1.0.4 material.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]