[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] nodedev: invert virIsCapableFCHost return value



On 29/03/13 11:31, Osier Yang wrote:
On 28/03/13 23:46, Ján Tomko wrote:
Both virIsCapableFCHost and virIsCapableVport return 0 when the
respective sysfs path is accessible.
---
  src/node_device/node_device_linux_sysfs.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/node_device/node_device_linux_sysfs.c b/src/node_device/node_device_linux_sysfs.c
index a1c3637..fd91430 100644
--- a/src/node_device/node_device_linux_sysfs.c
+++ b/src/node_device/node_device_linux_sysfs.c
@@ -46,7 +46,7 @@ detect_scsi_host_caps_linux(union _virNodeDevCapData *d)
        VIR_DEBUG("Checking if host%d is an FC HBA", d->scsi_host.host);
  -    if (virIsCapableFCHost(NULL, d->scsi_host.host)) {
+    if (virIsCapableFCHost(NULL, d->scsi_host.host) == 0) {
          d->scsi_host.flags |= VIR_NODE_DEV_CAP_FLAG_HBA_FC_HOST;
            if (virReadFCHost(NULL,

ACK, thanks for fixing my fault.

Worth for 1.0.4, so I pushed this.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]