[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix the stdout in print_job_progress()



On 03/29/2013 04:33 AM, Yanbing Du wrote:
> Signed-off-by: Yanbing Du <ydu redhat com>
> ---
>  tools/virsh-domain.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> index d1e6f9d..10b646f 100644
> --- a/tools/virsh-domain.c
> +++ b/tools/virsh-domain.c
> @@ -1407,7 +1407,7 @@ print_job_progress(const char *label, unsigned long long remaining,
>  
>      /* see comments in vshError about why we must flush */
>      fflush(stdout);
> -    fprintf(stderr, "\r%s: [%3d %%]", label, progress);
> +    fprintf(stdout, "\r%s: [%3d %%]", label, progress);

NACK.  Progress is intentionally reported to stderr (hence flushing
stdout before printing progress, and flushing stderr after).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]