[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 5/9] virCaps: get rid of emulatorRequired



On 03/15/2013 09:26 AM, Peter Krempa wrote:
> This patch removes the emulatorRequired field and associated
> infrastructure from the virCaps object. Instead the driver specific
> callbacks are used as this field isn't enforced by all drivers.
> 
> This patch implements the appropriate callbacks in the qemu and lxc
> driver and moves to check to that location.
> ---
> 
> Notes:
>     Version 4:
>     - rename virDomainDefDefaultEmulator to virDomainDefGetDefaultEmulator
>     - changed names of functions to comply with the rest
>     Version 3:
>     - new in the series
> 

> +static int
>  qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,
>                               virDomainDefPtr def ATTRIBUTE_UNUSED,
>                               virCapsPtr caps ATTRIBUTE_UNUSED,
>                               void *opaque)
> +
>  {

Spurious newline addition.

ACK with that cleaned up (again, assuming this series is post-release).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]