[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 7/9] virCaps: remove defaultDiskDriverType from the struct



On 03/15/2013 09:26 AM, Peter Krempa wrote:
> Use the qemu specific callback to fill this data in the qemu driver as
> it's the only place where it was used and fix tests as the qemu test
> capability object didn't configure the defaults for the tests.
> ---
> 
> Notes:
>     Version 4:
>     - new in series
> 
>  src/conf/capabilities.h                            |  1 -
>  src/conf/domain_conf.c                             |  5 ---
>  src/qemu/qemu_conf.c                               |  6 ----
>  src/qemu/qemu_domain.c                             | 42 ++++++++++++++++++----
>  .../qemuxml2argv-disk-drive-network-nbd.args       |  5 +--
>  .../qemuxml2argv-disk-drive-network-nbd.xml        |  1 +
>  .../qemuxml2argv-disk-drive-network-rbd-auth.args  |  2 +-
>  .../qemuxml2argv-disk-drive-network-rbd-ipv6.args  |  2 +-
>  .../qemuxml2argv-disk-drive-network-rbd-ipv6.xml   |  1 +
>  .../qemuxml2argv-disk-drive-network-rbd.args       |  2 +-
>  .../qemuxml2argv-disk-drive-network-rbd.xml        |  1 +
>  .../qemuxml2argv-disk-drive-network-sheepdog.args  |  3 +-
>  .../qemuxml2argv-disk-drive-network-sheepdog.xml   |  1 +
>  13 files changed, 47 insertions(+), 25 deletions(-)

This plus your followups looks fine.  ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]