[libvirt] [PATCH 14/25] conf: Introduce <shareable> for hostdev

[Osier Yang]

On 07/05/13 21:45, John Ferlan wrote:
> On 05/03/2013 02:07 PM, Osier Yang wrote:
>> >Unlike disk device, the scsi-generic always writethrough the data,
>> >so no need to introduce a "cache" tag, and set "cache=off".
>> >---
>> >  docs/formatdomain.html.in                          |  6 ++++
>> >  docs/schemas/domaincommon.rng                      |  5 +++
>> >  src/conf/domain_conf.c                             |  4 +++
>> >  src/conf/domain_conf.h                             |  1 +
>> >  .../qemuxml2argv-hostdev-scsi-shareable.xml        | 36 ++++++++++++++++++++++
>> >  tests/qemuxml2xmltest.c                            |  1 +
>> >  6 files changed, 53 insertions(+)
>> >  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-shareable.xml
>> >
>> >diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
>> >index 9cd79e5..6437d6d 100644
>> >--- a/docs/formatdomain.html.in
>> >+++ b/docs/formatdomain.html.in
>> >@@ -2410,6 +2410,12 @@
>> >        <dd>Indicates that the device is readonly, only supported by SCSI host
>> >          device now. <span class="since">Since 1.0.6</span>
>> >        </dd>
>> >+      <dt><code>shareable</code></dt>
>> >+      <dd>If present, this indicates the device is expected to be shared
>> >+        between domains (assuming the hypervisor and OS support this).
>> >+        Only supported by SCSI host device now.
> s/ now/
>
> Missed that above too I think in the previous review.
>
> ACK on the rest.
Thanks, pushed with the change.