[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/5] Add support for storage format in FS <driver>



On 04/22/2013 08:06 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Extend the <driver> element in filesystem devices to
> allow a storage format to be set. The new attribute
> uses 'format' to reflect the storage format. This is
> different from the <driver> element in disk devices
> which use 'type' to reflect the storage format. This
> is because the 'type' attribute on filesystem devices
> is already used for the driver backend, for which the
> disk devices use the 'name' attribute. Arggggh.
> 
> Anyway for disks we have
> 
>    <driver name="qemu" type="raw"/>
> 
> And for filesystems this change means we now have
> 
>    <driver type="loop" format="raw"/>
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  docs/formatdomain.html.in     | 24 ++++++++++++++
>  docs/schemas/domaincommon.rng | 73 ++++++++++++++++++++++++++++++-------------
>  src/conf/domain_conf.c        | 25 ++++++++++++---
>  src/conf/domain_conf.h        |  6 ++--
>  src/qemu/qemu_command.c       |  3 +-
>  5 files changed, 102 insertions(+), 29 deletions(-)

ACK; hope there's a test later in the series.


> +      <dt><code>driver</code></dt>
> +      <dd>
> +        The optional driver element allows specifying further details
> +        related to the hypervisor driver used to provide the filesystem.
> +        <span class="since">Since 1.0.4</span>

1.0.5 (you posted this before freeze, and it is isolated enough that I
think it is still safe to include in this release).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]