[libvirt] [sandbox PATCH] Add a option --rpm if rpm autodetection fail
Michael Scherer
misc at zarb.org
Wed May 1 13:03:00 UTC 2013
Le mercredi 01 mai 2013 à 13:20 +0100, Daniel P. Berrange a écrit :
> On Wed, May 01, 2013 at 01:13:55PM +0200, Michael Scherer wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=954187
> >
> > If someone use a custom unit file for the sandbox, the rpm
> > autodetection fail with a exception. Now, this will show
> > a error message, asking to use --rpm and use this rpm if
> > autodetection fail.
> > ---
> > bin/virt-sandbox-service | 46 +++++++++++++++++++++++++++++++++++++++++-----
> > 1 file changed, 41 insertions(+), 5 deletions(-)
>
> > @@ -1015,6 +1047,10 @@ def gen_create_args(subparser):
> > action=CheckUnit,
> > dest="unitfiles", default=[],
> > help=_("Systemd Unit file to run within the systemd sandbox container. Commands cannot be specified with unit files."))
> > + parser.add_argument("-r", "--rpm",
> > + action=CheckRpm,
> > + dest="rpm", default=None,
> > + help=_("Rpm configuration to use in the container. Default: autodetected from unit files, unless if using a custom unit file."))
>
> Although we currently only integrate with RPM that would change if someone
> ported it to non-Fedora/RHEL distros. As such we shouldn't expose any
> command line option named --rpm. Instead we should use a generic term
> like --package
Good point, resending it corrected
--
Michael Scherer
More information about the libvir-list
mailing list