[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 2/3] gconfig: Add GVirConfigDomainSnapshotDisk getters/setters



On Thu, May 02, 2013 at 06:22:14PM +0300, Zeeshan Ali (Khattak) wrote:
> On Wed, May 1, 2013 at 10:59 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> > +
> > +
> > +const char *gvir_config_domain_snapshot_disk_get_driver_type(GVirConfigDomainSnapshotDisk *disk)
> 
> Shouldn't 'driver_type' be an enum?

libvirt is storing it internally as a string, see
http://libvirt.org/git/?p=libvirt.git;a=blob;f=src/conf/snapshot_conf.c;h=5b54a28a596aef0bb883dfe12ca5c2f300a48999;hb=HEAD#l130
libvirt-gconfig generally follows what libvirt does when it comes to
choosing between strings and enums. This is also consistent with
gvir_config_domain_disk_set_driver_type().
However, the rng defines
http://libvirt.org/git/?p=libvirt.git;a=blob;f=docs/schemas/domaincommon.rng;h=10596dc0c0102b92494ee92dc7d0ea00a7894ef9;hb=HEAD#l1323
for this attribute.

Daniel, any recommendation?

Christophe

Attachment: pgp3zXalIbsxo.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]