[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: avoid useless virAsprintf



On 05/02/2013 02:28 PM, Laine Stump wrote:
> On 05/02/2013 03:36 PM, Eric Blake wrote:
>> virAsprintf(&foo, "%s", bar) is wasteful compared to
>> foo = strdup(bar) (or eventually, VIR_STRDUP(foo, bar),
>> but one thing at a time...).
>>
>> Noticed while reviewing Laine's attempt to clean up broken
>> qemu:///session.
> 
> Yeah, I noticed that too, and thought I had eliminated the one that was
> part of the patch, but I guess I just moved it instead  :-/
> 
> 
> ACK.

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]