[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] build: always include libvirt_lxc.syms in tarball



On a mingw build, 'make distcheck' fails with:

  GEN      libvirt_qemu.def
make[3]: *** No rule to make target `../../src/libvirt_lxc.syms', needed by `libvirt_lxc.def'.  Stop.

I traced it to a missing entry in EXTRA_DIST.  But rather than keep
the entire list in sync, it is easier to list the three syms files
that drive .so files directly, and then reuse existing makefile
variables for the remaining files (that is, I validated that all
remaining files are added to SYM_FILES, possibly via USED_SYM_FILES,
according to makefile conditionals).

* src/Makefile.am (EXTRA_DIST): Ensure all syms files are shipped.

Signed-off-by: Eric Blake <eblake redhat com>
---
 src/Makefile.am | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 299b8fd..6c2788c 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1548,20 +1548,11 @@ SYM_FILES += $(srcdir)/libvirt_atomic.syms
 endif

 EXTRA_DIST += \
-  libvirt_public.syms		\
-  libvirt_private.syms		\
-  libvirt_atomic.syms		\
-  libvirt_driver_modules.syms	\
-  libvirt_daemon.syms		\
-  libvirt_linux.syms		\
-  libvirt_esx.syms		\
-  libvirt_openvz.syms		\
-  libvirt_qemu.syms		\
-  libvirt_sasl.syms		\
-  libvirt_gnutls.syms		\
-  libvirt_vmx.syms		\
-  libvirt_xenxs.syms	\
-  libvirt_libssh2.syms
+	libvirt_public.syms		\
+	libvirt_lxc.syms		\
+	libvirt_qemu.syms		\
+	$(SYM_FILES)			\
+	$(NULL)

 GENERATED_SYM_FILES = \
 	libvirt.syms libvirt.def libvirt_qemu.def libvirt_lxc.def
-- 
1.8.1.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]