[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] Make detect_scsi_host_caps a function on all architectures



On 05/03/2013 12:22 AM, Guido Günther wrote:
> In the non linux case some callers like gather_scsi_host_caps needed the
> return code of -1 while others like update_caps needed an emtpy

s/emtpy/empty/

> statement (to avoid a "statement without effect" warning). This is much
> simpler solved by using a function instead of a define.
> ---
>  src/node_device/node_device_driver.h      |   11 +----------
>  src/node_device/node_device_linux_sysfs.c |   10 +++++++++-
>  2 files changed, 10 insertions(+), 11 deletions(-)

ACK.

> +int
> +detect_scsi_host_caps(union _virNodeDevCapData *d ATTRIBUTE_UNUSED)

It would eventually be nice to rename this virDetectScsiHostCaps, but
that can be a cleanup for another day; your patch is fine for the
build-breaker on FreeBSD that Roman reported.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]