[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Fixup rpcgen code on kFreeBSD too



On 05/03/2013 12:21 AM, Guido Günther wrote:
> since it uses glibc's rpcgen.
> ---
>  src/rpc/genprotocol.pl |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

ACK.

I suspect we could probably even remove the line completely, and instead
focus on making the script work for all common flavors of rpcgen (since
at least MacOS users have complained about it not working for them, and
since that was the original goal of the cleanup script), but that would
be a separate patch.

> 
> diff --git a/src/rpc/genprotocol.pl b/src/rpc/genprotocol.pl
> index c8c1570..f02ce13 100755
> --- a/src/rpc/genprotocol.pl
> +++ b/src/rpc/genprotocol.pl
> @@ -31,7 +31,7 @@ open RPCGEN, "-|", $rpcgen, $mode, $xdrdef
>  open TARGET, ">$target"
>      or die "cannot create $target: $!";
>  
> -my $fixup = $^O eq "linux" || $^O eq "cygwin";
> +my $fixup = $^O eq "linux" || $^O eq "cygwin" || $^O eq "gnukfreebsd";
>  
>  if ($mode eq "-c") {
>      print TARGET "#include <config.h>\n";
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]