[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3] rpc: message related sizes enlarged



On 07.05.2013 13:22, Viktor Mihajlovski wrote:
> From: Daniel Hansel <daniel hansel linux vnet ibm com>
> 
> We have seen an issue on s390x platform where domain XMLs larger than 1MB
> were used. The define command was finished successfully. The dumpxml command
> was not successful (i.e. could not encode message payload).
> 
> Enlarged message related sizes (e.g. maximum string size, message size, etc.)
> to handle larger system configurations used on s390x platform.
> 
> To improve handling of the RPC message size the allocation during encode process
> is changed to a dynamic one (i.e. starting with 64kB initial size and increasing
> that size in steps up to 16MB if the payload data is larger).
> 
> Signed-off-by: Daniel Hansel <daniel hansel linux vnet ibm com>
> Signed-off-by: Viktor Mihajlovski <mihajlov linux vnet ibm com>
> ---
> V2 Changes
>  - switch to dynamical allocation of RPC message buffers
>  - mention upstream version in libvirt.c
> 
> V3 Changes
>  - update version comment in libvirt.c to 1.0.6
> 
>  src/libvirt.c                |    4 ++++
>  src/remote/remote_protocol.x |    6 +++---
>  src/rpc/virnetmessage.c      |   46 ++++++++++++++++++++++++++++++++++--------
>  src/rpc/virnetmessage.h      |    3 ++-
>  src/rpc/virnetprotocol.x     |   16 +++++++++++----
>  tests/virnetmessagetest.c    |    2 +-
>  6 files changed, 60 insertions(+), 17 deletions(-)

ACK.

Now is the best time to push this so we have as much time for testing as
possible. So I've pushed this as well.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]