[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 17/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/qemu/*



On 05/03/2013 08:53 AM, Michal Privoznik wrote:
> ---
>  include/libvirt/libvirt.h.in |  10 +-
>  src/qemu/qemu_capabilities.c |  79 ++++----
>  src/qemu/qemu_cgroup.c       |   4 +-
>  src/qemu/qemu_command.c      | 419 +++++++++++++++++--------------------------
>  src/qemu/qemu_conf.c         |  58 +++---
>  src/qemu/qemu_domain.c       |  26 ++-
>  src/qemu/qemu_driver.c       | 113 ++++--------
>  src/qemu/qemu_hotplug.c      |  15 +-
>  src/qemu/qemu_migration.c    |  20 +--
>  src/qemu/qemu_monitor_json.c |  63 ++-----
>  src/qemu/qemu_monitor_text.c |  15 +-
>  src/qemu/qemu_process.c      |  64 +++----
>  src/remote/remote_driver.c   |   2 +-
>  13 files changed, 333 insertions(+), 555 deletions(-)

You don't mind if I save review for this till later, when I'm not as
tired?  It is one of the bigger patches, after all...

And 17/34 puts us at the halfway mark :)  Feel free to start pushing the
easier patches and/or posting followups for the issues I've found so
far, so we aren't forcing a respin of the entire series.  One benefit of
doing this early in the release cycle is we have more time to test
things before freeze to make sure we aren't hitting obvious regressions.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]