[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] conf: don't crash on a tpm device with no backends



On 09/05/13 18:36, Ján Tomko wrote:
Print an error instead of crashing when a TPM device without
a backend is specified.

https://bugzilla.redhat.com/show_bug.cgi?id=961252
---
  src/conf/domain_conf.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d55ce6b..eb579c6 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -6988,6 +6988,12 @@ virDomainTPMDefParseXML(const xmlNodePtr node,
          goto error;
      }
+ if (nbackends == 0) {
+        virReportError(VIR_ERR_XML_ERROR, "%s",
+                       _("missing TPM device backend"));
+        goto error;
+    }
+
      if (!(backend = virXMLPropString(backends[0], "type"))) {
          virReportError(VIR_ERR_XML_ERROR, "%s",
                         _("missing TPM device backend type"));
ACK.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]