[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 00/34] Introduce VIR_STRDUP



On 03.05.2013 16:53, Michal Privoznik wrote:
> Previously this aimed on dropping OOM report from almost
> everywhere (v1), then just prepare the ground (v2). Now, it just
> aims on introducing VIR_STRDUP and VIR_STRNDUP which do report
> OOM error. This will cause rebase conflicts, for sure. Sorry.
> 
> Patches available at:
>   git://gitorious.org/~zippy2/libvirt/michal-staging.git
>   branch oom4
> 
> 
> Michal Privoznik (34):
>   virstring: Introduce VIR_STRDUP and VIR_STRNDUP
>   Adapt to VIR_STRDUP and VIR_STRNDUP in daemon/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/conf/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/cpu/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/esx/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/hyperv/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/libxl/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/locking/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/lxc/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/network/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/node_device/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/interface/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/nwfilter/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/openvz/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/parallels/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/phyp/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/qemu/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/remote/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/rpc/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/secret/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/security/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/storage/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/test/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/uml/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/util/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/vbox/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/vmware/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/vmx/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/xen/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/xenapi/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/xenxs/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in tests/*
>   Adapt to VIR_STRDUP and VIR_STRNDUP in src/*
>   Introduce syntax-check rule to prefer VIR_STRDUP over strdup
> 
>  HACKING                                   |  11 +
>  cfg.mk                                    |   8 +
>  daemon/libvirtd-config.c                  |  50 ++--
>  daemon/libvirtd.c                         |  29 +--
>  daemon/remote.c                           | 161 +++++-------
>  docs/hacking.html.in                      |  14 +
>  include/libvirt/libvirt.h.in              |  10 +-
>  src/conf/capabilities.c                   |  30 +--
>  src/conf/cpu_conf.c                       |  19 +-
>  src/conf/domain_conf.c                    | 105 +++-----
>  src/conf/domain_event.c                   |  39 ++-
>  src/conf/node_device_conf.c               |  29 +--
>  src/conf/nwfilter_conf.c                  |  17 +-
>  src/conf/nwfilter_params.c                |  30 +--
>  src/conf/snapshot_conf.c                  |  11 +-
>  src/conf/storage_conf.c                   |  13 +-
>  src/conf/virchrdev.c                      |  12 +-
>  src/cpu/cpu_generic.c                     |   8 +-
>  src/cpu/cpu_map.c                         |   3 +-
>  src/cpu/cpu_powerpc.c                     |  13 +-
>  src/cpu/cpu_x86.c                         |  10 +-
>  src/datatypes.c                           |  76 +++---
>  src/esx/esx_driver.c                      |  43 +--
>  src/esx/esx_interface_driver.c            |   7 +-
>  src/esx/esx_network_driver.c              |  28 +-
>  src/esx/esx_storage_backend_iscsi.c       |  21 +-
>  src/esx/esx_storage_backend_vmfs.c        |  16 +-
>  src/esx/esx_util.c                        |  45 +---
>  src/esx/esx_vi.c                          |  79 ++----
>  src/esx/esx_vi_types.c                    |  36 +--
>  src/hyperv/hyperv_driver.c                |  50 +---
>  src/hyperv/hyperv_util.c                  |  18 +-
>  src/interface/interface_backend_udev.c    |  36 +--
>  src/libvirt.c                             |  14 +-
>  src/libvirt_private.syms                  |   2 +
>  src/libxl/libxl_conf.c                    |  86 ++----
>  src/libxl/libxl_driver.c                  |  14 +-
>  src/locking/lock_daemon.c                 |  30 +--
>  src/locking/lock_daemon_config.c          |  12 +-
>  src/locking/lock_daemon_dispatch.c        |   6 +-
>  src/locking/lock_driver_lockd.c           |  41 ++-
>  src/locking/lock_driver_sanlock.c         |  12 +-
>  src/locking/lock_manager.c                |   4 +-
>  src/lxc/lxc_cgroup.c                      |   3 +-
>  src/lxc/lxc_conf.c                        |  36 ++-
>  src/lxc/lxc_container.c                   |  18 +-
>  src/lxc/lxc_controller.c                  |  20 +-
>  src/lxc/lxc_driver.c                      |   9 +-
>  src/lxc/lxc_process.c                     |   7 +-
>  src/network/bridge_driver.c               |  34 +--
>  src/node_device/node_device_driver.c      |  33 +--
>  src/node_device/node_device_hal.c         |  13 +-
>  src/node_device/node_device_udev.c        |  99 ++-----
>  src/nodeinfo.c                            |   5 +-
>  src/nwfilter/nwfilter_dhcpsnoop.c         |  22 +-
>  src/nwfilter/nwfilter_driver.c            |   7 +-
>  src/nwfilter/nwfilter_ebiptables_driver.c |   2 +-
>  src/nwfilter/nwfilter_gentech_driver.c    |   5 +-
>  src/nwfilter/nwfilter_learnipaddr.c       |   5 +-
>  src/openvz/openvz_conf.c                  |  45 ++--
>  src/openvz/openvz_driver.c                |  39 ++-
>  src/parallels/parallels_driver.c          |  71 +++--
>  src/parallels/parallels_network.c         |  23 +-
>  src/parallels/parallels_storage.c         |  62 ++---
>  src/phyp/phyp_driver.c                    |  50 +---
>  src/qemu/qemu_capabilities.c              |  79 +++---
>  src/qemu/qemu_cgroup.c                    |   4 +-
>  src/qemu/qemu_command.c                   | 419 ++++++++++++------------------
>  src/qemu/qemu_conf.c                      |  58 ++---
>  src/qemu/qemu_domain.c                    |  26 +-
>  src/qemu/qemu_driver.c                    | 113 +++-----
>  src/qemu/qemu_hotplug.c                   |  15 +-
>  src/qemu/qemu_migration.c                 |  20 +-
>  src/qemu/qemu_monitor_json.c              |  63 ++---
>  src/qemu/qemu_monitor_text.c              |  15 +-
>  src/qemu/qemu_process.c                   |  64 ++---
>  src/remote/remote_driver.c                | 116 ++++-----
>  src/rpc/gendispatch.pl                    |  21 +-
>  src/rpc/virnetclient.c                    |  16 +-
>  src/rpc/virnetmessage.c                   |  12 +-
>  src/rpc/virnetsaslcontext.c               |   6 +-
>  src/rpc/virnetserver.c                    |   6 +-
>  src/rpc/virnetserverclient.c              |  10 +-
>  src/rpc/virnetservermdns.c                |   6 +-
>  src/rpc/virnetsocket.c                    |  10 +-
>  src/rpc/virnetsshsession.c                |  76 +++---
>  src/rpc/virnettlscontext.c                |  26 +-
>  src/secret/secret_driver.c                |   5 +-
>  src/security/security_apparmor.c          |  20 +-
>  src/security/security_dac.c               |  23 +-
>  src/security/security_nop.c               |   7 +-
>  src/security/security_selinux.c           |  79 ++----
>  src/security/virt-aa-helper.c             |   4 +-
>  src/storage/parthelper.c                  |   5 +-
>  src/storage/storage_backend.c             |  22 +-
>  src/storage/storage_backend_disk.c        |  26 +-
>  src/storage/storage_backend_fs.c          |  34 +--
>  src/storage/storage_backend_iscsi.c       |  17 +-
>  src/storage/storage_backend_logical.c     |  32 +--
>  src/storage/storage_backend_mpath.c       |   5 +-
>  src/storage/storage_backend_rbd.c         |   5 +-
>  src/storage/storage_backend_scsi.c        |  19 +-
>  src/storage/storage_backend_sheepdog.c    |   6 +-
>  src/storage/storage_driver.c              |  18 +-
>  src/test/test_driver.c                    | 144 ++++------
>  src/uml/uml_conf.c                        |  10 +-
>  src/uml/uml_driver.c                      |   8 +-
>  src/util/virauth.c                        |  17 +-
>  src/util/virauthconfig.c                  |   8 +-
>  src/util/virbitmap.c                      |   9 +-
>  src/util/vircgroup.c                      |  36 ++-
>  src/util/vircommand.c                     |  33 ++-
>  src/util/virconf.c                        |  34 +--
>  src/util/virdnsmasq.c                     |  22 +-
>  src/util/virebtables.c                    |  34 +--
>  src/util/virebtables.h                    |   2 +-
>  src/util/virerror.c                       |  19 +-
>  src/util/virhash.c                        |   5 +-
>  src/util/viridentity.c                    |  15 +-
>  src/util/virinitctl.c                     |   4 +-
>  src/util/viriptables.c                    |   4 +-
>  src/util/virjson.c                        |  18 +-
>  src/util/virkeyfile.c                     |  13 +-
>  src/util/virlockspace.c                   |  25 +-
>  src/util/virlog.c                         |  25 +-
>  src/util/virnetdevmacvlan.c               |  16 +-
>  src/util/virnetdevtap.c                   |  11 +-
>  src/util/virnetdevvportprofile.c          |   4 +-
>  src/util/virobject.c                      |  16 +-
>  src/util/virpci.c                         |  14 +-
>  src/util/virsexpr.c                       |  37 +--
>  src/util/virsocketaddr.c                  |   9 +-
>  src/util/virstoragefile.c                 |  18 +-
>  src/util/virstring.c                      |  91 ++++++-
>  src/util/virstring.h                      |  62 +++++
>  src/util/virsysinfo.c                     | 290 ++++++++-------------
>  src/util/virtypedparam.c                  |  14 +-
>  src/util/viruri.c                         |  58 ++---
>  src/util/virutil.c                        |  91 +++----
>  src/util/virxml.c                         |   5 +-
>  src/vbox/vbox_XPCOMCGlue.c                |   6 +-
>  src/vbox/vbox_tmpl.c                      | 278 +++++++++-----------
>  src/vmware/vmware_conf.c                  |  28 +-
>  src/vmware/vmware_driver.c                |  11 +-
>  src/vmx/vmx.c                             |  36 +--
>  src/xen/block_stats.c                     |  16 +-
>  src/xen/xen_driver.c                      |   9 +-
>  src/xen/xen_hypervisor.c                  |  19 +-
>  src/xen/xen_inotify.c                     |  15 +-
>  src/xen/xend_internal.c                   |  78 ++----
>  src/xen/xm_internal.c                     |   9 +-
>  src/xen/xs_internal.c                     |  44 ++--
>  src/xenapi/xenapi_driver.c                |  59 ++---
>  src/xenapi/xenapi_utils.c                 |  39 +--
>  src/xenxs/xen_sxpr.c                      | 192 ++++++--------
>  src/xenxs/xen_xm.c                        |  94 +++----
>  tests/commandhelper.c                     |  10 +-
>  tests/commandtest.c                       |   2 +-
>  tests/openvzutilstest.c                   |   6 +-
>  tests/qemumonitortestutils.c              |  15 +-
>  tests/qemuxml2argvtest.c                  |  23 +-
>  tests/qemuxmlnstest.c                     |   4 +-
>  tests/securityselinuxhelper.c             |   9 +-
>  tests/securityselinuxlabeltest.c          |   3 +-
>  tests/securityselinuxtest.c               |   9 +-
>  tests/storagebackendsheepdogtest.c        |   6 +-
>  tests/testutils.c                         |   4 +-
>  tests/testutilsqemu.c                     |   5 +-
>  tests/vircgrouptest.c                     |   2 +-
>  tests/virnetmessagetest.c                 |  21 +-
>  tests/vmx2xmltest.c                       |   9 +-
>  tests/xml2vmxtest.c                       |   9 +-
>  172 files changed, 2204 insertions(+), 3501 deletions(-)
> 

I've pushed some independent ACKed patches. Others, like 18/34 and 19/34
are ACKed, but require include/libvirt/libvirt.h.in changed made in yet
unreviewed 17/34 so I hold the push until then.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]