[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix naming of methods in ESX storage backends to follow public APIs

On 05/09/2013 07:12 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> The previous update of method naming missed the ESX storage
> backend files. Update them is that the driver impl methods
> follow the naming of the public API but with s/vir/esx/
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/esx/esx_storage_backend_iscsi.c | 104 ++++++++++++++++++------------------
>  src/esx/esx_storage_backend_vmfs.c  | 104 ++++++++++++++++++------------------
>  2 files changed, 104 insertions(+), 104 deletions(-)

ACK.  Mostly mechanical, and consistent with other patches.

Didn't you write a 'make check' rule that was supposed to catch
mismatches?  If so, doesn't that rule need to be updated to avoid
regressions in this file, since obviously this file escaped detection
the first time?

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]