[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/6] Workaround issue with clang and inline functions with static vars



On 05/13/2013 06:17 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Clang does not like it when you pass a static variable to an
> inline function
> 
>  vircgroupmock.c:462:22: error: static variable 'fakesysfsdir' is
>   used in an inline function with external linkage [-Werror,-Wstatic-in-inline]
> 
> Just make the var non-static to avoid this
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  tests/vircgroupmock.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

ACK.  I don't know if that is a case where gcc is silently allowing a
non-conforming extension beyond C99, or whether it is a case of clang
just being brain-dead; but either way, the workaround is painless enough
that I don't mind the wider visibility.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]