[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] Need better validation of <sysinfo> uuid



On 05/10/2013 10:52 AM, John Ferlan wrote:
>> If we parse and then format, we should use what we formatted from then
>> on, instead of the original user's (potentially unusual) formatting.
>>
> It would seem that you are thus advocating we change what was read 
> to be formatted properly and don't tell the user we did that, e.g.:
> 

<snip>

Yes, I think you're on the right track.

> 
> 
> Would it be better to see a v2 with everything?  
> Or push patches 1-3 and make a v2 of just this one?

It's okay to push your ack'd patches, then post a v2 of what remains;
and this time around, I was okay with your uuid patches, but had
questions on the date parsing that might deserve a v3.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]