[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 7/7] tests: Add tests for fc_host



On 05/14/2013 12:31 PM, Gene Czarcinski wrote:
> On 05/14/2013 01:42 PM, Osier Yang wrote:
>> On 15/05/13 00:35, Gene Czarcinski wrote:
>>> On 05/13/2013 05:32 AM, Osier Yang wrote:
>>>> On 08/05/13 23:03, Osier Yang wrote:
>>>>> On 08/05/13 21:53, John Ferlan wrote:
>>>>>> On 05/06/2013 08:45 AM, Osier Yang wrote:

[18k of super-quoted message snipped]

>>>> I misunderstood your meaning in 2/7, you meant the macros defined
>>>> for string, pushed the set and will post independant patches.
>>> NOTE!!
>>>
>>> Your test adds data but DOES NOT update Makefile.am
>>>
>>> Therefore. when you create a dist tarball and run the tests, the
>>> fchosttest will fail because it cannot find its data because the data
>>> is NOT included in the tarball.
>>
>> Fixed by commit 1cc8259bfe17be51eb1
> Thanks!

Just a reminder that it is okay to delete portions of a quoted mail that
are no longer relevant to the topic being discussed, to cut down on the
amount of bandwidth consumed by the list engine, as well as time spent
by readers in scrolling to the meat of the message.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]