[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemu: detect -machine mem-merge capability



On 05/13/2013 11:25 PM, Osier Yang wrote:
> From: Eric Blake <eblake redhat com>

I'm a biased reviewer, if you want to wait for someone else to also
chime in...

> 
> * src/qemu/qemu_capabilities.h: New capability bit.
> * src/qemu/qemu_capabilities.c (virQEMUCapsProbeQMPCommandLine): New
> function, based on qemuMonitorGetCommandLineOptionParameters, which was
> introduced by commit bd56d0d813; use it to set new capability bit.
> (virQEMUCapsInitQMP): Use new function.
> ---
>  src/qemu/qemu_capabilities.c | 37 +++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_capabilities.h |  1 +
>  2 files changed, 38 insertions(+)
> 

ACK, and glad you've been able to test it with your patch 2.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]