[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-tck PATCH v2 3/3] add new script for migration max speed



Get it, very thanks!

----- Original Message -----
> From: "Eric Blake" <eblake redhat com>
> Cc: "Daniel P. Berrange" <berrange redhat com>, "Zhe Peng" <zpeng redhat com>, libvir-list redhat com
> Sent: Wednesday, May 15, 2013 1:01:24 AM
> Subject: Re: [libvirt] [libvirt-tck PATCH v2 3/3] add new script for migration max speed
> 
> On 05/14/2013 10:58 AM, Eric Blake wrote:
> > On 05/14/2013 08:50 AM, Daniel P. Berrange wrote:
> >> On Fri, May 10, 2013 at 03:17:54PM +0800, Zhe Peng wrote:
> >>> new script for migrate max speed APIs
> >>> dom->migrate_get_max_speed
> >>> dom->migrate_set_max_speed
> >>> ---
> >>>  scripts/domain/301-migration-max-speed.t |   64
> >>>  ++++++++++++++++++++++++++++
> >>>  1 files changed, 64 insertions(+), 0 deletions(-)
> >>>  create mode 100644 scripts/domain/301-migration-max-speed.t
> >>
> >> ACK
> > 
> > All three patches pushed now.
> 
> Minor correction - my attempt to push was rejected until I touched up
> your patch to fix these whitespace problems:
> 
> Compressing objects: 100% (15/15), done.
> Writing objects: 100% (15/15), 4.29 KiB, done.
> Total 15 (delta 10), reused 0 (delta 0)
> remote: scripts/domain/121-block-info.t:19: trailing whitespace.
> remote: +domain/121-block-info.t
> remote: scripts/domain/121-block-info.t:128: trailing whitespace.
> remote: +#qcow2 file start with hexadecimal:0x51 0x46 0x49 (ASCII: "QFI")
> remote: scripts/domain/121-block-info.t:1: new blank line at EOF.
> remote: scripts/domain/180-interface-parameters.t:19: trailing whitespace.
> remote: +domain/180-interface-parameters.t - test interface set/get
> remote: scripts/domain/180-interface-parameters.t:59: trailing whitespace.
> remote: +my %params = (Sys::Virt::Domain::BANDWIDTH_IN_AVERAGE=>1000,
> Sys::Virt::Domain::BANDWIDTH_IN_PEAK=>1001,
> remote: scripts/domain/180-interface-parameters.t:60: trailing whitespace.
> remote: +              Sys::Virt::Domain::BANDWIDTH_IN_BURST=>1002,
> Sys::Virt::Domain::BANDWIDTH_OUT_AVERAGE=>1003,
> remote: scripts/domain/301-migration-max-speed.t:19: trailing whitespace.
> remote: +domain/301-migrate-max-speed.t - test migrate max speed set/get
> remote: scripts/domain/301-migration-max-speed.t:1: new blank line at EOF.
> remote: error: hook declined to update refs/heads/master
> To ssh://libvirt.org/git//libvirt-tck.git
>  ! [remote rejected] master -> master (hook declined)
> 
> You can set up git to refuse bad whitespace locally, to make it easier
> for others to not have to clean up your patches later.
> 
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 
> 

-- 
Best Regards
Zhe Peng


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]