[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] tests: Move fchostdata into sysfsroot



On 15/05/13 23:36, Daniel P. Berrange wrote:
On Wed, May 15, 2013 at 11:25:20PM +0800, Osier Yang wrote:
"fchostdata" is also about sysfs files, it can go home now.
---
  tests/Makefile.am                                     | 1 -
  tests/fchostdata/fc_host/host4/fabric_name            | 1 -
  tests/fchostdata/fc_host/host4/max_npiv_vports        | 1 -
  tests/fchostdata/fc_host/host4/node_name              | 1 -
  tests/fchostdata/fc_host/host4/npiv_vports_inuse      | 1 -
  tests/fchostdata/fc_host/host4/port_name              | 1 -
  tests/fchostdata/fc_host/host4/port_state             | 1 -
  tests/fchostdata/fc_host/host4/vport_create           | 0
  tests/fchostdata/fc_host/host4/vport_delete           | 0
  tests/fchostdata/fc_host/host5/fabric_name            | 1 -
  tests/fchostdata/fc_host/host5/max_npiv_vports        | 1 -
  tests/fchostdata/fc_host/host5/node_name              | 1 -
  tests/fchostdata/fc_host/host5/npiv_vports_inuse      | 1 -
  tests/fchostdata/fc_host/host5/port_name              | 1 -
  tests/fchostdata/fc_host/host5/port_state             | 1 -
  tests/fchostdata/fc_host/host5/vport_create           | 0
  tests/fchostdata/fc_host/host5/vport_delete           | 0
  tests/fchosttest.c                                    | 2 +-
  tests/sysfsroot/class/fc_host/host4/fabric_name       | 1 +
  tests/sysfsroot/class/fc_host/host4/max_npiv_vports   | 1 +
  tests/sysfsroot/class/fc_host/host4/node_name         | 1 +
  tests/sysfsroot/class/fc_host/host4/npiv_vports_inuse | 1 +
  tests/sysfsroot/class/fc_host/host4/port_name         | 1 +
  tests/sysfsroot/class/fc_host/host4/port_state        | 1 +
  tests/sysfsroot/class/fc_host/host4/vport_create      | 0
  tests/sysfsroot/class/fc_host/host4/vport_delete      | 0
  tests/sysfsroot/class/fc_host/host5/fabric_name       | 1 +
  tests/sysfsroot/class/fc_host/host5/max_npiv_vports   | 1 +
  tests/sysfsroot/class/fc_host/host5/node_name         | 1 +
  tests/sysfsroot/class/fc_host/host5/npiv_vports_inuse | 1 +
  tests/sysfsroot/class/fc_host/host5/port_name         | 1 +
  tests/sysfsroot/class/fc_host/host5/port_state        | 1 +
  tests/sysfsroot/class/fc_host/host5/vport_create      | 0
  tests/sysfsroot/class/fc_host/host5/vport_delete      | 0
  34 files changed, 13 insertions(+), 14 deletions(-)
  delete mode 100644 tests/fchostdata/fc_host/host4/fabric_name
  delete mode 100644 tests/fchostdata/fc_host/host4/max_npiv_vports
  delete mode 100644 tests/fchostdata/fc_host/host4/node_name
  delete mode 100644 tests/fchostdata/fc_host/host4/npiv_vports_inuse
  delete mode 100644 tests/fchostdata/fc_host/host4/port_name
  delete mode 100644 tests/fchostdata/fc_host/host4/port_state
  delete mode 100644 tests/fchostdata/fc_host/host4/vport_create
  delete mode 100644 tests/fchostdata/fc_host/host4/vport_delete
  delete mode 100644 tests/fchostdata/fc_host/host5/fabric_name
  delete mode 100644 tests/fchostdata/fc_host/host5/max_npiv_vports
  delete mode 100644 tests/fchostdata/fc_host/host5/node_name
  delete mode 100644 tests/fchostdata/fc_host/host5/npiv_vports_inuse
  delete mode 100644 tests/fchostdata/fc_host/host5/port_name
  delete mode 100644 tests/fchostdata/fc_host/host5/port_state
  delete mode 100644 tests/fchostdata/fc_host/host5/vport_create
  delete mode 100644 tests/fchostdata/fc_host/host5/vport_delete
  create mode 100644 tests/sysfsroot/class/fc_host/host4/fabric_name
  create mode 100644 tests/sysfsroot/class/fc_host/host4/max_npiv_vports
  create mode 100644 tests/sysfsroot/class/fc_host/host4/node_name
  create mode 100644 tests/sysfsroot/class/fc_host/host4/npiv_vports_inuse
  create mode 100644 tests/sysfsroot/class/fc_host/host4/port_name
  create mode 100644 tests/sysfsroot/class/fc_host/host4/port_state
  create mode 100644 tests/sysfsroot/class/fc_host/host4/vport_create
  create mode 100644 tests/sysfsroot/class/fc_host/host4/vport_delete
  create mode 100644 tests/sysfsroot/class/fc_host/host5/fabric_name
  create mode 100644 tests/sysfsroot/class/fc_host/host5/max_npiv_vports
  create mode 100644 tests/sysfsroot/class/fc_host/host5/node_name
  create mode 100644 tests/sysfsroot/class/fc_host/host5/npiv_vports_inuse
  create mode 100644 tests/sysfsroot/class/fc_host/host5/port_name
  create mode 100644 tests/sysfsroot/class/fc_host/host5/port_state
  create mode 100644 tests/sysfsroot/class/fc_host/host5/vport_create
  create mode 100644 tests/sysfsroot/class/fc_host/host5/vport_delete

Not sure I really agree with this change. The 'fchostdata' files are
used by the 'fchosttest.c' test program. So that existing naming is
following our conventions of naming the data dir to match the test
program.

My intention was to put all the sysfs test input files together in a
directory, and keep the tree similar with real "sysfs". IMHO it's
better than having different sysfs test input files here and there,
and orgnize the tree of each of them in different manner?

Osier


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]