[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] maint: use LGPL correctly



On 05/16/2013 02:23 AM, Eric Blake wrote:
> Several files called out COPYING or COPYING.LIB instead of using
> the normal boilerplate.  It's especially important that we don't
> call out COPYING from an LGPL file, since COPYING is traditionally
> used for the GPL.  A few files were lacking copyright altogether.
> 
> * src/rpc/gendispatch.pl: Add missing copyright.
> * src/rpc/genprotocol.pl: Spell out license terms.

Since we add the copyright here (in files not distributed in the
tarball), should we maybe add it also to other build-helper scripts
(both perl and shell ones)?

[...]
> Any other files where I should add a copyright notice?
> 

Copyrights are mostly correct, but I had a look at licenses as well and
mentioned those files as well.  Correct me if I'm wrong, but I think
some of these files should have copyright added (only where we have it)
and all of the are missing a license:

src/driver.h
src/internal.h
src/check-symfile.pl
src/check-symsorting.pl

src/vbox/vbox_V3_2.c
src/vbox/vbox_V4_0.c
src/vbox/vbox_V4_1.c


I'm not sure about license/copyright in:

Makefile.nonreentrant

tools/virt-pki-validate.in
tools/virt-sanlock-cleanup.in

python/*.{py,c,h}


And these probably don't need license since it's "AS-IS" now:

src/util/virhash.c
src/util/virhash.h

[...]
> diff --git a/src/xen/xend_internal.h b/src/xen/xend_internal.h
> index 7332303..16521d5 100644
> --- a/src/xen/xend_internal.h
> +++ b/src/xen/xend_internal.h
> @@ -1,16 +1,26 @@
>  /*
>   * xend_internal.h
>   *
> - * Copyright (C) 2006-2008, 2010-2012 Red Hat, Inc.
> + * Copyright (C) 2006-2008, 2010-2013 Red Hat, Inc.
>   * Copyright (C) 2005,2006
>   *
> - *      Anthony Liguori <aliguori us ibm com>
> - *	Daniel Veillard <veillard redhat com>
>   *

I think these lines belong together as it doesn't just mean "Authors"
but also to whom the last copyright belongs.  I'd add Anthony and DV in
the line of the copyright.

Anyway, ACK.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]