[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] maint: enforce correct copyright usage



On 05/16/2013 02:23 AM, Eric Blake wrote:
> To ensure we don't regress and cause the need for further
> cleanups, add a 'make syntax-check' rule that ensures new
> files have proper copyright contents.
> 
> * cfg.mk (sc_copyright_file): New rule.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
>  cfg.mk | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/cfg.mk b/cfg.mk
> index e013195..f1715e4 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -688,6 +688,13 @@ sc_copyright_address:
>  	halt='Point to <http://www.gnu.org/licenses/>, not an address'	\
>  	  $(_sc_search_regexp)
> 
> +# We have to ship COPYING (GPL) alongside COPYING.LESSER (LGPL), but
> +# we want source files to be explicit that they are LGPL.
> +sc_copyright_file:
> +	@prohibit='COPYING([^.]|\.LIB)'					\

COPYING.asdf and similar wouldn't match, but we don't need to take care
of that.

> +	halt='Refer to COPYING.LESSER for LGPL'				\
> +	  $(_sc_search_regexp)
> +
>  # Some functions/macros produce messages intended solely for developers
>  # and maintainers.  Do not mark them for translation.
>  sc_prohibit_gettext_markup:
> @@ -856,6 +863,9 @@ exclude_file_name_regexp--sc_bindtextdomain = ^(tests|examples)/
>  exclude_file_name_regexp--sc_copyright_address = \
>    ^COPYING(|\.LESSER)$$
> 
> +exclude_file_name_regexp--sc_copyright_file = \
> +  ^COPYING(|\.LESSER)|cfg\.mk|libvirt.spec.in$$
> +
>  exclude_file_name_regexp--sc_flags_usage = ^(docs/|src/util/virnetdevtap\.c$$|tests/vircgroupmock\.c$$)
> 
>  exclude_file_name_regexp--sc_libvirt_unmarked_diagnostics = \
> 

ACK,

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]