[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] tests: Move fchostdata into sysfsroot



On Thu, May 16, 2013 at 12:37:23AM +0800, Osier Yang wrote:
> On 15/05/13 23:36, Daniel P. Berrange wrote:
> >On Wed, May 15, 2013 at 11:25:20PM +0800, Osier Yang wrote:
> >>"fchostdata" is also about sysfs files, it can go home now.
> >>---
> >
> >Not sure I really agree with this change. The 'fchostdata' files are
> >used by the 'fchosttest.c' test program. So that existing naming is
> >following our conventions of naming the data dir to match the test
> >program.
> >
> My intention was to put all the sysfs test input files together in a
> directory, and keep the tree similar with real "sysfs". IMHO it's
> better than having different sysfs test input files here and there,
> and orgnize the tree of each of them in different manner?

The different trees of files are specific to each particular test
case though. Unless there are multiple test cases which are all
using the same file, they should be named to match the test case


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]