[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] xencapstest: Resolve Coverity CHECKED_RETURN error



On 05/16/2013 08:01 AM, John Ferlan wrote:
> The return from virInitialize() needs to be checked.
> ---
>  tests/xencapstest.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

ACK.

> 
> diff --git a/tests/xencapstest.c b/tests/xencapstest.c
> index e220234..8bdd6cd 100644
> --- a/tests/xencapstest.c
> +++ b/tests/xencapstest.c
> @@ -161,7 +161,8 @@ mymain(void)
>      int ret = 0;
>  
>      xenHypervisorInit(&hv_versions);
> -    virInitialize();
> +    if (virInitialize() < 0)
> +        return EXIT_FAILURE;
>  
>      if (virtTestRun("Capabilities for i686, no PAE, no HVM",
>                      1, testXeni686, NULL) != 0)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]