[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Add support for locking domain's memory pages



On 05/16/2013 06:41 AM, Jiri Denemark wrote:
> ---
>  docs/formatdomain.html.in                          | 26 +++++++++++++---------
>  docs/schemas/domaincommon.rng                      |  5 +++++
>  src/conf/domain_conf.c                             | 20 +++++++++--------
>  src/conf/domain_conf.h                             |  1 +

Can we split this into two patches; one that adds the new XML (and
documents in the commit message what it looks like),

>  src/qemu/qemu_capabilities.c                       |  2 ++
>  src/qemu/qemu_capabilities.h                       |  1 +
>  src/qemu/qemu_command.c                            | 11 +++++++++

...and one that implements the new feature in qemu?

>  tests/qemuxml2argvdata/qemuxml2argv-mlock-off.args |  4 ++++
>  tests/qemuxml2argvdata/qemuxml2argv-mlock-off.xml  | 15 +++++++++++++
>  tests/qemuxml2argvdata/qemuxml2argv-mlock-on.args  |  4 ++++
>  tests/qemuxml2argvdata/qemuxml2argv-mlock-on.xml   | 18 +++++++++++++++
>  .../qemuxml2argv-mlock-unsupported.args            |  4 ++++
>  .../qemuxml2argv-mlock-unsupported.xml             | 15 +++++++++++++
>  tests/qemuxml2argvtest.c                           |  5 +++++

I'm not sure how the tests are best split between the two patches, as
long as 'make check' passes across both patches.

ACK.  The patch itself didn't have anything that caught my eye, other
than my request to split it into functional pieces.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]