[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] schema: make source optional in volume XML



On 05/16/2013 09:48 PM, Eric Blake wrote:
> On 05/16/2013 08:39 AM, Ján Tomko wrote:
>> We don't parse it anyway.
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=893273
>> ---
>>  docs/schemas/storagevol.rng                    |  4 +++-
>>  tests/Makefile.am                              |  3 ++-
>>  tests/storagevolschemadata/qcow2-no-source.xml | 29 ++++++++++++++++++++++++++
>>  tests/storagevolschematest                     |  2 +-
>>  4 files changed, 35 insertions(+), 3 deletions(-)
>>  create mode 100644 tests/storagevolschemadata/qcow2-no-source.xml
>>
> 
>> +++ b/tests/Makefile.am
>> @@ -73,11 +73,12 @@ EXTRA_DIST =		\
>>  	securityselinuxlabeldata \
>>  	schematestutils.sh \
>>  	sexpr2xmldata \
>> -	storagepoolschemadata \
>>  	storagepoolschematest \
>> +	storagepoolschemadata \
> 
> Why the change to unsorted?

It's what I had in 1/2 originally and I didn't rebase 2/2 correctly after I
fixed it.

> 
> ACK with that spurious change undone.

Thanks, I've undone it and pushed the series.

Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]