[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Include GNULIB mkdtemp module



On 05/17/2013 07:29 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The mkdtemp function is missing on mingw platforms. It is
> used in various Linux specific places in libvirt, but
> recently became used in fdstreamtest.c which is cross
> platform. Thus the GNULIB mkdtemp module should be used
> to proide mkdtemp.

s/proide/provide/

> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  bootstrap.conf | 1 +
>  1 file changed, 1 insertion(+)

ACK with a nit:

> 
> diff --git a/bootstrap.conf b/bootstrap.conf
> index 6e03757..616eee1 100644
> --- a/bootstrap.conf
> +++ b/bootstrap.conf
> @@ -73,6 +73,7 @@ maintainer-makefile
>  manywarnings
>  mkostemp
>  mkostemps
> +mkdtemp

Keep this list sorted.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]