[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] qemu: report useful error failling to destroy domain gracefully



On 05/17/2013 08:31 AM, Guannan Ren wrote:
> Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=927620
> 
>  #kill -STOP `pidof qemu-kvm`
>  #virsh destroy $guest --graceful
>  error: Failed to destroy domain testVM
>  error: An error occurred, but the cause is unknown
> 
> With --graceful, SIGTERM always is emitted to kill driver
> process, but it won't success till burning out waiting time
> in case of process being stopped.
> But domain destroy without --graceful can work, SIGKILL will
> be emitted to the stopped process after 10 secs which always
> kills a process even one that is currently stopped.
> So report an error after burning out waiting time in this case.
> ---
>  src/qemu/qemu_process.c | 2 +-
>  src/util/virprocess.c   | 5 +++--
>  2 files changed, 4 insertions(+), 3 deletions(-)

ACK.

> +++ b/src/qemu/qemu_process.c
> @@ -3930,7 +3930,7 @@ qemuProcessKill(virDomainObjPtr vm, unsigned int flags)
>          }
>      }
>  
> -    if ((flags & VIR_QEMU_PROCESS_KILL_NOWAIT)) {
> +    if (flags & VIR_QEMU_PROCESS_KILL_NOWAIT) {

Technically unrelated churn, but doesn't hurt to include it.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]