[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-perl PATCH] interface: list active and inactive interface by default



On Mon, May 20, 2013 at 09:44:46PM +0800, Guannan Ren wrote:
> flags with 0 can not list interfaces, use flags in libvirt.h
> by default to list all of active and inactive interfaces
> 
>  VIR_CONNECT_LIST_INTERFACES_INACTIVE = 1 << 0
>  VIR_CONNECT_LIST_INTERFACES_ACTIVE   = 1 << 1
> ---
>  Virt.xs | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Virt.xs b/Virt.xs
> index a22cd2f..ea45e34 100644
> --- a/Virt.xs
> +++ b/Virt.xs
> @@ -1980,7 +1980,8 @@ list_all_domains(con, flags=0)
>  
>  
>  void
> -list_all_interfaces(con, flags=0)
> +list_all_interfaces(con, flags=VIR_CONNECT_LIST_INTERFACES_ACTIVE|
> +                               VIR_CONNECT_LIST_INTERFACES_INACTIVE)
>        virConnectPtr con;
>        unsigned int flags;
>   PREINIT:


NACK,  using flags=0 should return a list of all interfaces.
The flags only need to be set if you want to filter the list
to some subset.  If that isn't working, then it is a bug in
libvirt, not the Perl binding.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]