[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Implement esxDomainGetMetadata for VIR_DOMAIN_METADATA_DESCRIPTION



On 05/18/2013 04:00 PM, Matthias Bolte wrote:
> ---
>  src/esx/esx_driver.c |   47 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 
> diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
> index b23e7f6..f53b9c4 100644
> --- a/src/esx/esx_driver.c
> +++ b/src/esx/esx_driver.c
> @@ -5211,6 +5211,52 @@ no_memory:
>  #undef MATCH
>  
>  
> +
> +static char *
> +esxDomainGetMetadata(virDomainPtr domain, int type,
> +                     const char *uri ATTRIBUTE_UNUSED,
> +                     unsigned int flags)
> +{
> +    char *result = NULL;
> +    esxPrivate *priv = domain->conn->privateData;
> +    esxVI_String *propertyNameList = NULL;
> +    esxVI_ObjectContent *virtualMachine = NULL;
> +
> +    if (flags != VIR_DOMAIN_AFFECT_LIVE) {
> +        virReportError(VIR_ERR_INVALID_ARG, _("unsupported flags: (0x%x)"), flags);
> +        return NULL;
> +    }

Are you intentionally rejecting VIR_DOMAIN_AFFECT_CURRENT?

ACK if you can answer why or fix that.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]