[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 30/31] nwfitler: Change the comment style

On 21/05/13 23:35, Eric Blake wrote:
On 05/21/2013 04:01 AM, Osier Yang wrote:
The more common habit is to add the comment after the statements.
  src/nwfilter/nwfilter_dhcpsnoop.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcpsnoop.c
index b9921e5..451c783 100644
--- a/src/nwfilter/nwfilter_dhcpsnoop.c
+++ b/src/nwfilter/nwfilter_dhcpsnoop.c
@@ -369,7 +369,7 @@ virNWFilterSnoopListAdd(virNWFilterSnoopIPLeasePtr plnew,
for (pl = *end; pl && plnew->timeout < pl->timeout;
           pl = pl->prev)
-        /* empty */ ;
+        ; /* empty */
How did you determine which style was more common?  Do you have 'git
grep | wc' numbers to back your claim?  I guess putting the comment
after makes it easier to avoid false positives in patch 31?

Yes, you are right. :-)

As far I saw when writing the script to exclude the empty statements,
all other comments for an empty statements are after ";"

I did notice a couple of empty while loops in earlier patches (let me
search for them again...)

found it: patch 8/31.  Reply coming up there, soon.

ACK to all patches up to 30 where I didn't explicitly reply.

Pushed 1 to 30. Thanks.

Weak ack to this one (I don't care if it goes in, but I also don't mind
if it gets omitted).

I leave this one for more opinion, if there is no more opinion till
tomorrow, will push it.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]