[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 31/31] syntax-check: Add the rule to forbid whitespace before "; "



On 21/05/13 23:40, Eric Blake wrote:
On 05/21/2013 04:01 AM, Osier Yang wrote:
Only a few cases are allowed:

1) The expression is empty for "for" loop, E.g.

   for (i = 0; ; i++)

2) An empty statement

   while (write(statuswrite, &status, 1) == -1 &&
          errno == EINTR)
       ; /* empty */

3) ";" is inside double-quote, I.e, as part of const string. E.g.

   vshPrint(ctl, "a ; b ; cd;\n");

The "for" loop in src/rpc/virnettlscontext.c is the special case,
1) applies for it, so change it together in this patch.
---
  build-aux/bracket-spacing.pl | 18 ++++++++++++++++++
  src/rpc/virnettlscontext.c   |  2 +-
  2 files changed, 19 insertions(+), 1 deletion(-)
ACK.


Pushed.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]