[libvirt] [PATCH RESENT 01/12] libxl: allow script for any network interface, not only bridge
Jim Fehlig
jfehlig at suse.com
Wed May 22 14:23:17 UTC 2013
Jim Fehlig wrote:
> Jim Fehlig wrote:
>
>> Laine Stump wrote:
>>
>>
>>> On 04/10/2013 05:10 AM, Daniel P. Berrange wrote:
>>>
>>>
>>>
>>>> On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote:
>>>>
>>>>
>>>>
>>>>> This can be useful for route or NAT networks, or any other custom
>>>>> network setup. Especially configuration example in documentation uses
>>>>> <script/> tag with type 'ethernet'.
>>>>> ---
>>>>> src/libxl/libxl_conf.c | 17 +++++------------
>>>>> 1 file changed, 5 insertions(+), 12 deletions(-)
>>>>>
>>>>>
>>>>>
>>>> The script should not not have been allowed for type='bridge' in
>>>> the first place, it is only intended for type='ethernet' usage
>>>> and nothing else.
>>>>
>>>>
>>>>
>>> I thought that it was also allowed/necessary for type='bridge' in xen
>>> domains. Is this incorrect?
>>>
>>>
>>>
>> I think it is only necessary if something other than the default
>> (/etc/xen/scripts/vif-bridge) is desired. It has been allowed in both
>> xen drivers for as long as I remember.
>>
>>
>
> Any consensus here? I double-checked the legacy xen driver and it does
> in fact support <script> for <interface type='bridge'>. I'm not sure how
> many users specify something other than the default, but I'm loath to
> break them when moving from the old xen toolstack to libxl.
>
> Marek,
>
> Assuming we continue to allow <script> for type='bridge' interfaces in
> the libxl driver, you'll have to change your patch to only allow it for
> type 'bridge' and 'ethernet'.
>
Please send a V2 with this change.
Regards,
Jim
More information about the libvir-list
mailing list