[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 11/12] LXC: controller: change the owner of /dev/pts and ptmx to the root of container



On 05/23/2013 01:56 PM, Richard RW. Weinberger wrote:
> Hi!
> 
> ----- Urspr√ľngliche Mail -----
>> This two files are created for container,
>> the owner should be the root user of container.
>>
>> Signed-off-by: Gao feng <gaofeng cn fujitsu com>
>> ---
>>  src/lxc/lxc_controller.c | 30 ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>
>> diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
>> index b2ace20..7d27135 100644
>> --- a/src/lxc/lxc_controller.c
>> +++ b/src/lxc/lxc_controller.c
>> @@ -1506,8 +1506,15 @@
>> virLXCControllerSetupDevPTS(virLXCControllerPtr ctrl)
>>      char *opts = NULL;
>>      char *devpts = NULL;
>>      char *path = NULL;
>> +    uid_t uid = (uid_t)-1;
>> +    gid_t gid = (gid_t)-1;
>>      int ret = -1;
>>  
>> +    if (ctrl->def->idmap.uidmap) {
>> +        uid = ctrl->def->idmap.uidmap[0].target;
>> +        gid = ctrl->def->idmap.gidmap[0].target;
>> +    }
>> +
> 
> You're using this pattern a few times.
> Maybe it's worth a helper function.
> 

Yep, it's what we did in PATCH 12/12.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]