[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 10/13] Adapt to VIR_STRDUP and VIR_STRNDUP in src/xen/*



On 05/23/2013 09:07 AM, Michal Privoznik wrote:

> 
> Would it be possible to rather:
> 
> diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c
> index 41eb928..7c05911 100644
> --- a/src/xen/xm_internal.c
> +++ b/src/xen/xm_internal.c
> @@ -1171,8 +1171,6 @@ xenXMListDefinedDomains(virConnectPtr conn, char
> **const names, int maxnames)
>      if (ctx.oom) {
>          for (i = 0; i < ctx.count; i++)
>              VIR_FREE(ctx.names[i]);
> -
> -        virReportOOMError();
>          goto cleanup;

Yes, I like that better.  ACK with that change.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]