[libvirt] [PATCH] syntax-check: ignore all quoted strings in bracket-spacing
Eric Blake
eblake at redhat.com
Fri May 24 14:26:26 UTC 2013
On 05/24/2013 03:26 AM, Ján Tomko wrote:
> Ignore strings with an escaped double quote too.
>
> This removes the need for special handling of quotes in the
> semicolon check.
> ---
> build-aux/bracket-spacing.pl | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
Hmm, our semicolon check enforces no leading spaces, but we could
probably improve it to also enforce trailing space in a for loop. For
example, this looks odd:
src/conf/interface_conf.c: for (i = 0; i < nbItf;i++) {
compared to
for (i = 0; i < nbItf; i++) {
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130524/905d9b53/attachment-0001.sig>
More information about the libvir-list
mailing list