[libvirt] [PATCH] util/vshstring: fix the vir_strdup when src is NULL.

yangdongsheng yangds.fnst at cn.fujitsu.com
Tue May 28 07:13:17 UTC 2013


When src is NULL, vir_strdup will return 0 directly.
This patch will set dest to NULL before vir_strdup return.

Signed-off-by: yangdongsheng <yangds.fnst at cn.fujitsu.com>
---
 src/util/virstring.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/util/virstring.c b/src/util/virstring.c
index b244e6c..25b5d81 100644
--- a/src/util/virstring.c
+++ b/src/util/virstring.c
@@ -540,8 +540,10 @@ virStrdup(char **dest,
           const char *funcname,
           size_t linenr)
 {
-    if (!src)
+    if (!src) {
+        *dest = NULL;
         return 0;
+    }
     if (!(*dest = strdup(src))) {
         if (report)
             virReportOOMErrorFull(domcode, filename, funcname, linenr);
-- 
1.7.10.1




More information about the libvir-list mailing list