[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] syntax-check: mandate space after mid-line semicolon



On 05/25/2013 03:13 PM, Martin Kletzander wrote:
>> @@ -31,6 +32,9 @@ foreach my $file (@ARGV) {
>>      while (defined (my $line = <FILE>)) {
>>          my $data = $line;
>>
>> +        # Kill any quoted ; or "
>> +        $data =~ s,'[";]','X',g;
>> +
> 
> Good catch, I didn't know this was missing.

Yep, I hit some false positives where we parse for ';' if I didn't add this.

> 
> [...]
> 
> ACK,

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]