[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: drop unused variable



On 05/28/2013 05:20 PM, Eric Blake wrote:
> Compilation for mingw failed:
> 
> ../../src/util/virutil.c: In function 'virGetWin32DirectoryRoot':
> ../../src/util/virutil.c:1094:9: error: unused variable 'ret' [-Werror=unused-variable]
> 
> * src/util/virutil.c (virGetWin32DirectoryRoot): Silence compiler
> warning.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---

I pushed this under the build-breaker rule, by the way.

> 
> Compilation still fails in the tests directory, due to the use of
> fprintf(stderr, "%zu", size_t); I'm still debating whether I can
> get it fixed in gnulib and take the risk of a gnulib backport before
> rc2, or whether we'll have to come up with some other less-invasive
> workaround.

Dan already posted a potential workaround, but he put it on hold pending
whatever I can determine on the gnulib side of things.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]