[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Document that runtime changes may be lost after S4 suspend



On 05/31/2013 10:03 AM, Jiri Denemark wrote:
> ---
>  src/libvirt.c   | 7 +++++++
>  tools/virsh.pod | 7 +++++++
>  2 files changed, 14 insertions(+)

ACK.

> 
> diff --git a/src/libvirt.c b/src/libvirt.c
> index b129611..6967613 100644
> --- a/src/libvirt.c
> +++ b/src/libvirt.c
> @@ -2472,6 +2472,13 @@ error:
>   * Dependent on hypervisor used, this may require a
>   * guest agent to be available, e.g. QEMU.
>   *
> + * Beware that at least for QEMU, the domain's process will be terminated
> + * when VIR_NODE_SUSPEND_TARGET_DISK is used and a new process will be
> + * launched when libvirt is asked to wake up the domain. As a result of
> + * this, any runtime changes, such as device hotplug or memory settings,
> + * are lost unless such changes were made with VIR_DOMAIN_AFFECT_CONFIG
> + * flag.
> + *
>   * Returns: 0 on success,
>   *          -1 on failure.
>   */
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index 11984bc..7c8ce18 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -1680,6 +1680,13 @@ hypervisor driver and 0 should be used.).
>  Note that this command requires a guest agent configured and running in the
>  domain's guest OS.
>  
> +Beware that at least for QEMU, the domain's process will be terminated when
> +target disk is used and a new process will be launched when libvirt is asked
> +to wake up the domain. As a result of this, any runtime changes, such as
> +device hotplug or memory settings, are lost unless such changes were made
> +with I<--config> flag.
> +
> +
>  =item B<dompmwakeup> I<domain>
>  
>  Wakeup a domain from pmsuspended state (either suspended by dompmsuspend or
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]