[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: skip qemu in tests when !WITH_QEMU



On 05/31/2013 10:50 AM, Eric Blake wrote:

> * tests/testutilsqemu.h: Make content conditional.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
> 
> Pushing under the build-breaker rule.  I'm getting closer to a
> clean ./autobuild.sh run.
> 
>  tests/testutilsqemu.h | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/testutilsqemu.h b/tests/testutilsqemu.h
> index 2ca42ab..fc2f5bd 100644
> --- a/tests/testutilsqemu.h
> +++ b/tests/testutilsqemu.h
> @@ -1,8 +1,11 @@
> +#include <config.h>

Oops, I violated my own rule (but fixed it before pushing) - config.h
should never be included from another .h file, because all .c files
should have included it first.  Sounds like I need to write a syntax
check...

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]