[libvirt] [PATCH] python: prefer PyList_SET_ITEM to PyList_SetItem

Giuseppe Scrivano gscrivan at redhat.com
Wed Nov 6 12:29:39 UTC 2013


Martin Kletzander <mkletzan at redhat.com> writes:

> Oh, you're right.  I was blinded by the fact, that PyList_SetItem()
> checks whether the 'op' is a list and I was under the impression that
> PyList_Check(op) will catch that.  This has not yet changed (I checked
> 3.3.2), so you're right, the fact that we'll use PyList_SET_ITEM won't
> change a thing.  I'll continue with the review in a minute.  Thanks
> for the idea.

If you haven't done the review yet, I can send you a new version in a
while that adds error checking for PyList_New.  If you already worked on
the review, then I can split these additional changes and rebase them.

Thanks,
Giuseppe




More information about the libvir-list mailing list