[libvirt] [PATCH 6/6] qemuProcessReconnectHelper: Don't create joinable thread

Martin Kletzander mkletzan at redhat.com
Thu Nov 14 11:55:12 UTC 2013


On Thu, Nov 14, 2013 at 10:51:16AM +0100, Michal Privoznik wrote:
> In the qemuProcessReconnectHelper() a new thread that do all the

s/do/does/

> interesting work is spawned. The rationale is to not block the daemon
> startup process in case of unresponsive qemu. However, the thread
> handler is a local variable which gets lost once the control goes out of
> scope. Hence, the thread gets leaked. We can avoid this if the thread

s/,// ???

> isn't make joinable.
> 

s/make/made/

> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_process.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

ACK,

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131114/762ad26f/attachment-0001.sig>


More information about the libvir-list mailing list