[libvirt] [PATCHv3 3/3] Return -1 in virPortAllocatorAcquire if all ports are used

[Martin Kletzander]

On Wed, Nov 13, 2013 at 06:01:42PM +0100, Ján Tomko wrote:
> Report the error in virPortAllocatorAcquire instead
> of doing it in every caller.
> 
> The error contains the port range name instead of the intended
> use for the port, e.g.:
> Unable to find an unused port in range 'display' (65534-65535)
> instead of:
> Unable to find an unused port for SPICE
> 
> This also adds error reporting when the QEMU driver could not
> find an unused port for VNC, VNC WebSockets or NBD migration.
> ---
>  src/libxl/libxl_conf.c       |  5 -----
>  src/qemu/qemu_migration.c    | 16 ++--------------
>  src/qemu/qemu_process.c      | 11 -----------
>  src/util/virportallocator.c  |  7 ++++++-
>  tests/virportallocatortest.c |  6 ++----
>  5 files changed, 10 insertions(+), 35 deletions(-)
> 

ACK,

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131114/dc66b23e/attachment-0001.sig>