[libvirt] [PATCHv3 2/3] Add a name to virPortAllocator

Ján Tomko jtomko at redhat.com
Mon Nov 18 11:39:49 UTC 2013


On 11/14/2013 02:13 PM, Martin Kletzander wrote:
> On Wed, Nov 13, 2013 at 06:01:41PM +0100, Ján Tomko wrote:
>> This allows its error messages to be more specific.
>> ---
>>  src/libxl/libxl_driver.c     | 3 ++-
>>  src/qemu/qemu_driver.c       | 9 ++++++---
>>  src/util/virportallocator.c  | 9 +++++++--
>>  src/util/virportallocator.h  | 3 ++-
>>  tests/virportallocatortest.c | 4 ++--
>>  5 files changed, 19 insertions(+), 9 deletions(-)
>>
> 
> You leak the *name.  ACK if you add VIR_FREE(pa->name) into
> virPortAllocatorDispose().
> 
> Martin
> 

I have fixed the leak and pushed the series, thank you for the reviews!

Jan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131118/86dacce4/attachment-0001.sig>


More information about the libvir-list mailing list